Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Academic page tabs and exams timeline #1379

Open
wants to merge 8 commits into
base: ui/redesign
Choose a base branch
from

Conversation

thePeras
Copy link
Member

@thePeras thePeras commented Nov 3, 2024

Closes #1377

Final result:
This may need little adjustments in the future to add more space, but good for now

Roadmap

@thePeras thePeras changed the base branch from develop to ui/redesign November 4, 2024 21:01
Copy link

codecov bot commented Nov 4, 2024

Codecov Report

Attention: Patch coverage is 5.98291% with 110 lines in your changes missing coverage. Please review.

Project coverage is 12%. Comparing base (0d8b0af) to head (e3b63df).
Report is 1 commits behind head on ui/redesign.

Additional details and impacted files
@@             Coverage Diff             @@
##           ui/redesign   #1379   +/-   ##
===========================================
- Coverage           12%     12%   -0%     
===========================================
  Files              266     267    +1     
  Lines             7201    7270   +69     
===========================================
+ Hits               806     810    +4     
- Misses            6395    6460   +65     

@thePeras thePeras marked this pull request as ready for review November 11, 2024 14:23
@thePeras thePeras requested a review from a team November 11, 2024 14:24
@thePeras thePeras mentioned this pull request Nov 11, 2024
7 tasks
@limwa
Copy link
Member

limwa commented Nov 12, 2024

Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button).
Maybe we could put it above the title or next to "MT"?

@thePeras
Copy link
Member Author

thePeras commented Nov 12, 2024

Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button). Maybe we could put it above the title or next to "MT"?

The ux would be compromised with your suggestions. We need a button to allow fat fingers ^.^

@DGoiana
Copy link
Collaborator

DGoiana commented Nov 12, 2024

Do not forget to add the timeline.

@limwa
Copy link
Member

limwa commented Nov 12, 2024

Just as a personal comment, I don't like how much horizontal space is "wasted" for something that very few people use (the hide button). Maybe we could put it above the title or next to "MT"?

The ux would be compromised with your suggestions. We need a button to allow fat fingers ^.^

That ultimately depends on how big the "hitbox" is. You can have a small-medium icon with a big hitbox. Doesn't compromise on UX and is more visually pleasing. Either way, if this doesn't work, imo we should try to come up with a solution that does.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement exams' page
3 participants